Repository navigation
Conversation
|
Thanks for working on support for older CMake versions, and sorry for the long wait. Making the build work on more toolchains is welcome, but I can't merge this PR as it stands. It contains two separate changes: 1. FindPythonLibs fallback for CMake < 3.12.4. I'm closing this part without prejudice. The fallback has some problems:
If you'd like to try again, a resubmission is welcome. A version that picks the fallback based on the features actually used, finds the numpy include path (for example by asking the Python interpreter for 2. Reindentation of the rest of Thanks again for the contribution! 🤖 This review was made by the project's automated governance process. See the README for details. |
The repository currently does not support CMake versions 3.8 to 3.12.4 because the FindPython3.cmake module was not added until 3.12.4 and the minimum CMake version for the project is set to 3.8. This PR adds the necessary CMake code to still correctly compile and link to the relevant Python libraries.